rdblue commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r529091768
##########
File path: core/src/main/java/org/apache/iceberg/V1Metadata.java
##########
@@ -356,7 +356,7 @@ public Object get(int pos) {
@Override
public void put(int i, Object v) {
- throw new UnsupportedOperationException("Cannot read into
IndexedDataFile");
+ throw new UnsupportedOperationException("Cannot write into
IndexedDataFile");
Review comment:
This doesn't add NaN counts to v1 metadata, but there's no reason why we
can't. Adding a new column to v1 metadata files is forward compatible and is
allowed, so we can go ahead and add it here. That way, even v1 benefits.
The reason why this is a v2 feature is that we are creating additional
requirements for writers: NaN must not be written as a lower or upper bound in
Iceberg metadata. Writers that want to write NaN counts in v1 should be able to
do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
