jbewing commented on code in PR #15373:
URL: https://github.com/apache/iceberg/pull/15373#discussion_r2853316851
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java:
##########
@@ -86,15 +86,19 @@ public class TestParquetVectorizedReads extends
AvroDataTestBase {
"RLE_DICTIONARY",
"DELTA_BINARY_PACKED",
"DELTA_LENGTH_BYTE_ARRAY",
- "DELTA_BYTE_ARRAY");
+ "DELTA_BYTE_ARRAY",
+ "BYTE_STREAM_SPLIT");
private static final Map<String, PrimitiveType> GOLDEN_FILE_TYPES =
- ImmutableMap.of(
- "string", Types.StringType.get(),
- "float", Types.FloatType.get(),
- "int32", Types.IntegerType.get(),
- "int64", Types.LongType.get(),
- "binary", Types.BinaryType.get(),
- "boolean", Types.BooleanType.get());
+ ImmutableMap.<String, PrimitiveType>builder()
Review Comment:
Yup! All golden files are expected to have a "_with_nulls" variant that gets
picked up here:
https://github.com/apache/iceberg/blob/d2fbe427ecec298f1600260f40fcab1b7ab2e695/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/data/vectorized/parquet/TestParquetVectorizedReads.java#L501-L510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
