mbutrovich commented on code in PR #2175:
URL: https://github.com/apache/iceberg-rust/pull/2175#discussion_r2853425163
##########
crates/iceberg/src/arrow/delete_file_loader.rs:
##########
@@ -64,6 +64,7 @@ impl BasicDeleteFileLoader {
self.file_io.clone(),
false,
None,
+ None,
Review Comment:
We now pass it through from the manifest as well. Thanks!
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -2097,6 +2110,7 @@ message schema {
) -> Vec<Option<String>> {
let tasks = Box::pin(futures::stream::iter(
vec![Ok(FileScanTask {
+ file_size_in_bytes: 0,
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
