zhangjun0x01 commented on issue #1791:
URL: https://github.com/apache/iceberg/issues/1791#issuecomment-732762830
In the first PR, I currently only implement the first method
`listPartitions(ObjectPath tablePath)`.
the `listPartitions(ObjectPath tablePath, CatalogPartitionSpec
partitionSpec)` method requires a CatalogPartitionSpec parameter, and the type
of the `CatalogPartitionSpec#partitionSpec ` is Map<String, String>. I tested
it, the filter in iceberg needs to match the value and type.
For example, if the partition type is int, we need to pass `123`. pass
`"123"` is wrong, so I think we may need to improve the
CatalogPartitionSpec#partitionSpec of flink to Map<String, Object> so that
more compatibility
The `listPartitionsByFilter(ObjectPath tablePath, List<Expression>
filters)` method need to transform the expression of flink to the expression of
iceberg. I think it will also need a lot of work.
So I think we can implement the first method first, and then implement the
other two methods in sub-PR later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
