deniskuzZ commented on code in PR #15389:
URL: https://github.com/apache/iceberg/pull/15389#discussion_r2854801633
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -78,6 +78,7 @@ enum TransactionType {
private TableMetadata base;
private TableMetadata current;
private boolean hasLastOpCommitted;
+ private boolean isAborted = false;
Review Comment:
> Can you confirm that the coordinator calls .commit() on each individual
operation before calling commitTransaction()?
Coordinator calls `txn.commiTransaction()` for every registered table !!!!
Client is using txn to stage the changes (i.e. txn.newAppend()...commit() ->
`BaseTransaction`.`TransactionTableOperations`.commit(), etc).
`PendingUpdate` are staged and applied only during commiTransaction()
````
for (PendingUpdate update : updates) {
// re-commit each update in the chain to apply it and update current
update.commit();
}
underlyingOps.commit(base, current)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
