dttung2905 commented on code in PR #16:
URL: https://github.com/apache/iceberg-terraform/pull/16#discussion_r2869977395
##########
internal/provider/provider.go:
##########
@@ -41,20 +43,24 @@ func New() func() provider.Provider {
// icebergProvider is the provider implementation.
type icebergProvider struct {
- catalogURI string
- catalogType string
- token string
- warehouse string
- headers map[string]string
+ catalogURI string
+ catalogType string
+ token string
+ warehouse string
+ headers map[string]string
+ polarisManagementURI string
+ polarisCatalogName string
}
// icebergProviderModel maps provider schema data to a Go type.
type icebergProviderModel struct {
- CatalogURI types.String `tfsdk:"catalog_uri"`
- Type types.String `tfsdk:"type"`
- Token types.String `tfsdk:"token"`
- Warehouse types.String `tfsdk:"warehouse"`
- Headers types.Map `tfsdk:"headers"`
+ CatalogURI types.String `tfsdk:"catalog_uri"`
+ Type types.String `tfsdk:"type"`
+ Token types.String `tfsdk:"token"`
+ Warehouse types.String `tfsdk:"warehouse"`
+ Headers types.Map `tfsdk:"headers"`
+ PolarisManagementURI types.String `tfsdk:"polaris_management_uri"`
+ PolarisCatalogName types.String `tfsdk:"polaris_catalog_name"`
Review Comment:
Not sure if we should name it like this? Whats gonna happen if we support
other implementation of REST catalog ? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
