pvary commented on PR #15489: URL: https://github.com/apache/iceberg/pull/15489#issuecomment-3983513073
My question: - Is dropping other dialects is intentional, or it is a bug? I see 2 use-cases: - Adding a new dialect, or fixing the error in the specific dialect. In this case the engine should read all the old dialects and add back the unchanged ones during the update. - Changing the actual query by the user. In this case if the other representations are not updated then we make a an inconsistent view. Better to delete the dialects the engine is unaware of. Given these 2 use-cases, it might be better of not adding the new config, and forcing the engines to consciously decide one or the other. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
