svalaskevicius commented on PR #15492: URL: https://github.com/apache/iceberg/pull/15492#issuecomment-3983680192
hi, @osscm I don't see how do I use it for the use case where we want to process our application's stuff first on the shutdown? i.e. is there a way to opt-out of the default `shutdown hook` and invoke it manually later on? this PR is also missing [S3OutputStream.java](https://github.com/apache/iceberg/pull/15312/changes#diff-7883582b4a4aa07e2c25d94e55959d23cfc2ad8e2721b5c1881a2cd2a5205a44) change where it still uses guava. `shutdownAll()` function seems to be waiting for each executor to terminate independently, adding the `terminationTimeoutMs` and increasing the total wait time to potentially `N*terminationTimeoutMs` It seems to me this PR is implemented very similarly, in effect, to #15312 , lacking some fixes and features from there, but would be happy with whichever @mxm chooses, as long as we can opt out of the default shutdown hook and invoke it manually (and the missed file is added, and the other fixes). Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
