nastra commented on code in PR #15488:
URL: https://github.com/apache/iceberg/pull/15488#discussion_r2872860270
##########
.github/workflows/jmh-benchmarks.yml:
##########
@@ -97,11 +97,22 @@ jobs:
- run: echo -e "$(ip addr show eth0 | grep "inet\b" | awk '{print $2}' |
cut -d/ -f1)\t$(hostname -f) $(hostname -s)" | sudo tee -a /etc/hosts
- name: Run Benchmark
- run: ./gradlew :iceberg-spark:${{ github.event.inputs.spark_version
}}:jmh -PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{
matrix.benchmark }}.txt
+ run: ./gradlew -DsparkVersions=${{ github.event.inputs.spark_version }}
:iceberg-spark:iceberg-spark-${{ github.event.inputs.spark_version }}:jmh
-PjmhIncludeRegex=${{ matrix.benchmark }} -PjmhOutputPath=benchmark/${{
matrix.benchmark }}.txt
- - uses: actions/upload-artifact@v7
+ - uses: actions/upload-artifact@v6
if: ${{ always() }}
with:
- name: benchmark-results
+ name: benchmark-${{ matrix.benchmark }}
path: |
**/benchmark/*.txt
+
+ merge-results:
Review Comment:
can you please elaborate why this is needed now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
