glitchy commented on PR #2185: URL: https://github.com/apache/iceberg-rust/pull/2185#issuecomment-3990707325
> Hey! This is exactly the PR I was about to implement but I was going to add the wiring for DataFusion also so you can do `INSERT OVERWRITE` I think it's not a lot of extra code to modify `IcebergCommitExec` to take `InsertOp`. I'm happy to add this is a follow-up PR if you were wanting to focus on the core iceberg part. Thanks @xanderbailey. Yep I wanted to keep this PR focused on the core Iceberg transaction layer. A follow-up PR wiring it into DataFusion with `INSERT OVERWRITE` via `IcebergCommitExec` would be great--happy to review it once this one lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
