yyanyy commented on a change in pull request #1803:
URL: https://github.com/apache/iceberg/pull/1803#discussion_r529992729
##########
File path: core/src/main/java/org/apache/iceberg/V1Metadata.java
##########
@@ -356,7 +356,7 @@ public Object get(int pos) {
@Override
public void put(int i, Object v) {
- throw new UnsupportedOperationException("Cannot read into
IndexedDataFile");
+ throw new UnsupportedOperationException("Cannot write into
IndexedDataFile");
Review comment:
Sure! I wasn't sure if I wanted to add it v1 since v1 was an established
version, and I don't know if introducing new attributes would be considered as
breaking people's assumption on the file contract (e.g. if some people have
their own version of manifest entry parser). But I guess the chance of this
happening would probably be rare, and should be easy to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
