sumedhsakdeo commented on code in PR #5077:
URL: https://github.com/apache/iceberg/pull/5077#discussion_r2881946780
##########
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##########
@@ -78,4 +86,65 @@ public static CloseableIterable<CombinedScanTask>
planTasks(CloseableIterable<Fi
splitFiles),
BaseCombinedScanTask::new);
}
+
+ @SuppressWarnings("unchecked")
+ public static <T extends ScanTask> CloseableIterable<ScanTaskGroup<T>>
planTaskGroups(CloseableIterable<T> tasks,
+
long splitSize, int lookback,
+
long openFileCost) {
+
+ Preconditions.checkArgument(splitSize > 0, "Invalid split size (negative
or 0): %s", splitSize);
+ Preconditions.checkArgument(lookback > 0, "Invalid split planning lookback
(negative or 0): %s", lookback);
+ Preconditions.checkArgument(openFileCost >= 0, "Invalid file open cost
(negative): %s", openFileCost);
+
+ // capture manifests which can be closed after scan planning
+ CloseableIterable<T> splitTasks = CloseableIterable.combine(
+ FluentIterable.from(tasks).transformAndConcat(task -> {
+ if (task instanceof SplittableScanTask<?>) {
+ return ((SplittableScanTask<? extends T>) task).split(splitSize);
+ } else {
+ return ImmutableList.of(task);
+ }
+ }),
+ tasks);
+
+ Function<T, Long> weightFunc = task -> Math.max(task.sizeBytes(),
task.filesCount() * openFileCost);
Review Comment:
This is resulting in unbalanced bin-packing. Interestingly previous function
planTasks was handling it correctly.
See
https://github.com/apache/iceberg/pull/5077/changes#diff-0b0affef002de35215ed5459cf6963fd0d5bf6d5403e67440b7ef97a35189454L70
Was there any particular reason to deviate for planTaskGroups?
CC: @teamurko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
