mxm commented on code in PR #15458:
URL: https://github.com/apache/iceberg/pull/15458#discussion_r2883981393
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/TriggerManagerOperator.java:
##########
@@ -252,7 +252,10 @@ public void close() throws Exception {
@VisibleForTesting
void handleLockRelease(LockReleaseEvent event) {
- Preconditions.checkArgument(lockTime != null, "Lock time is null, Can't
release lock");
+ if (lockTime == null) {
+ LOG.warn("Lock time is null, Can't release lock");
+ return;
+ }
Review Comment:
Instead of removing the Precondition, should we avoid sending out the
LockReleaseEvent when we're shutting down?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
