aokolnychyi commented on code in PR #15240:
URL: https://github.com/apache/iceberg/pull/15240#discussion_r2886910785
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java:
##########
@@ -23,8 +23,14 @@ public class SparkReadOptions {
private SparkReadOptions() {}
- // Snapshot ID of the table snapshot to read
- public static final String SNAPSHOT_ID = "snapshot-id";
+ // legacy time travel option that is no longer supported
+ public static final String LEGACY_SNAPSHOT_ID = "snapshot-id";
Review Comment:
Whoever uses these constants are going to be broken in any case, so better
be explicit.
I can go for DEPRECATED_XXX but it usually means still supported. Hence, I
went for LEGACY. I don't have a preference, really. @amogh-jahagirdar, what do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
