Copilot commented on code in PR #15515:
URL: https://github.com/apache/iceberg/pull/15515#discussion_r2887162097
##########
gradlew:
##########
@@ -87,7 +87,7 @@ APP_BASE_NAME=${0##*/}
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) ||
exit
if [ ! -e $APP_HOME/gradle/wrapper/gradle-wrapper.jar ]; then
- curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar
https://raw.githubusercontent.com/gradle/gradle/v8.14.4/gradle/wrapper/gradle-wrapper.jar
+ curl -o $APP_HOME/gradle/wrapper/gradle-wrapper.jar
https://raw.githubusercontent.com/gradle/gradle/v9.4.0/gradle/wrapper/gradle-wrapper.jar
Review Comment:
The wrapper download uses an unquoted `$APP_HOME/...` path in the `curl -o`
argument. If the repo is checked out under a directory containing spaces or
glob characters, the download can fail or write to an unintended location.
Quote the output path (and ideally the URL), and consider failing the script on
download errors (e.g., curl exit status / `-f`) so a partial/HTML response
doesn’t silently become `gradle-wrapper.jar`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
