nastra commented on code in PR #15511:
URL: https://github.com/apache/iceberg/pull/15511#discussion_r2889353059
##########
core/src/test/java/org/apache/iceberg/TestSnapshotProducer.java:
##########
@@ -158,4 +160,68 @@ public void
testCommitValidationWithCustomSummaryProperties() throws IOException
// Verify the table wasn't updated
assertThat(table.snapshots()).hasSize(1);
}
+
+ @TestTemplate
+ public void manifestNotCleanedUpWhenSnapshotNotLoadableAfterCommit() {
Review Comment:
the test mainly hits the `else` branch in `SnapshotProducer` and thus skips
manifest cleanup but I wasn't able to reproduce the theoretical issue that
stuff is accidentally cleaned up and causes corrupt metadata so far
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
