laskoviymishka commented on code in PR #769:
URL: https://github.com/apache/iceberg-go/pull/769#discussion_r2891863966


##########
catalog/glue/glue.go:
##########
@@ -65,6 +65,13 @@ const (
        SkipArchive        = "glue.skip-archive"
        SkipArchiveDefault = true
 
+       // GlueSchemaColumns controls whether schema columns are written to the 
Glue
+       // StorageDescriptor on table create/update. Set to "false" to omit 
columns,
+       // which avoids exceeding Glue's API payload limit for tables with very 
large
+       // schemas. Note: disabling columns breaks Athena column discovery via 
Glue.
+       GlueSchemaColumns        = "glue.schema-columns"

Review Comment:
   well, that's a case, it's something new.
   
   This is a new property, it doesn't exist in iceberg-java or pyiceberg today. 
However, it follows the established glue.* namespace convention used 
consistently across implementations (e.g. glue.skip-archive, glue.id, 
glue.endpoint).
   
   The Java community attempted to introduce something similar twice — 
glue.non-current-fields-disabled in apache/iceberg#11334 and 
apache/iceberg#12664 — both targeting the narrower problem of  
historical/non-current fields. Those PRs stalled and were closed due to 
inactivity without consensus, i would try to make them merged later, i think 
this has value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to