liukun4515 commented on pull request #1819:
URL: https://github.com/apache/iceberg/pull/1819#issuecomment-733405329


   > Also, per design doc, `older_than` is optional and should be defaulted to 
`System.currentTimeMillis()` if not set.
   > 
   > Then we can keep only a given number of snapshots:
   > 
   > ```
   > CALL catalog.schema.expire_snapshots(
   >   namespace => 'namespace_name',
   >   table => 'table_name',
   >   retain_last => 100
   > )
   > ```
   
   The the default `older_than`(`System.currentTime`) is a very dangerous.
   
   If some one not give the `older_than` value, all the snapshots will be 
dropped.
   
   @chenjunjiedada 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to