bryanck commented on code in PR #15193:
URL: https://github.com/apache/iceberg/pull/15193#discussion_r2896312113


##########
spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -642,6 +643,9 @@ public void testFilesTableTimeTravelWithSchemaEvolution() 
throws Exception {
         .append();
 
     Table table = Spark3Util.loadIcebergTable(spark, tableName);
+    Long previousSnapshotId = table.currentSnapshot().snapshotId();
+    // remember the time when the first snapshot was valid
+    long previousSnapshotTimestamp = System.currentTimeMillis();

Review Comment:
   Using the snapshot time seems more appropriate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to