rdblue commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2897940306
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/BaseReader.java:
##########
@@ -83,11 +85,13 @@ abstract class BaseReader<T, TaskT extends ScanTask>
implements Closeable {
BaseReader(
Table table,
+ FileIO fileIO,
ScanTaskGroup<TaskT> taskGroup,
Schema expectedSchema,
boolean caseSensitive,
boolean cacheDeleteFilesOnExecutors) {
this.table = table;
+ this.fileIO = fileIO;
Review Comment:
I think that I would combine the `FileIO` with the `EncryptionManager` here,
rather than in `inputFiles`. This makes the most sense for how this class may
evolve over time because we don't want to create more than one
`EncryptingFileIO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
