RussellSpitzer commented on code in PR #15514:
URL: https://github.com/apache/iceberg/pull/15514#discussion_r2898031335


##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -738,6 +741,75 @@ public void testEqualityDeleteWithSchemaEvolution() throws 
IOException {
     assertThat(actual).hasSize(expectedRecordCount);
   }
 
+  /**
+   * Covers a bug where equality deletes columns are appended to the required 
schema in a different
+   * order than the table schema, which can cause different deleteSchema 
orderings, poisoning the
+   * cache.
+   */
+  @TestTemplate

Review Comment:
   https://gist.github.com/sfc-gh-rspitzer/e53841222262010847a68aa2ed59dd39 < 
Here is what Claude thinks that should look like. I haven't really gone through 
it in depth I just figured if I was writing an implementation of DeleteFilter 
and DeleteLoader we are going way off track.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to