steveloughran commented on PR #15494: URL: https://github.com/apache/iceberg/pull/15494#issuecomment-4019262162
@mxm thank's for the analysis and insight. I just checked the hadoop codebase for the comment "fall through" with any form of computation between the cases. The JenkinsHash hash algorithm is the only place where something has taken serious advantage of fall through; the remaining 20 uses are fairly minimal. The only one which is my fault is error handling and highlights that code is due for a cleanup. It really highlights how the classic C design solved a problem which doesn't exist in high level code while adding a new problem "unintentional fall through". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
