singhpk234 commented on code in PR #15530:
URL: https://github.com/apache/iceberg/pull/15530#discussion_r2902030817
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -162,11 +162,11 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
} catch (CommitFailedException e) {
throw e;
} catch (RuntimeException persistFailure) {
- boolean isAwsServiceException = persistFailure instanceof
AwsServiceException;
Review Comment:
lets keep this and use in the variable below
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -176,7 +176,7 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
// If we got an AWS exception we would usually handle, but find we
// succeeded on a retry that threw an exception, skip the exception.
- if (commitStatus != CommitStatus.SUCCESS && isAwsServiceException) {
+ if (commitStatus == CommitStatus.FAILURE && persistFailure instanceof
AwsServiceException) {
Review Comment:
why did we remove the commitStatus != SUCCESS ? how about UNKNOWN status for
this ?
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -350,6 +350,14 @@ void persistGlueTable(
}
}
+ private static boolean isDeterministicGlueFailure(RuntimeException
exception) {
+ return exception instanceof ConcurrentModificationException
+ || exception instanceof
software.amazon.awssdk.services.glue.model.AlreadyExistsException
+ || exception instanceof EntityNotFoundException
+ || exception instanceof AccessDeniedException
+ || exception instanceof
software.amazon.awssdk.services.glue.model.ValidationException;
+ }
Review Comment:
worth adding java doc for why these failure is considerted as failed ?
also suggest renaming the funciton name a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
