anshulbaliga7 commented on code in PR #15520:
URL: https://github.com/apache/iceberg/pull/15520#discussion_r2903002763
##########
docs/docs/configuration.md:
##########
@@ -216,6 +216,24 @@ Here are the catalog properties related to locking. They
are used by some catalo
## Hadoop configuration
+### HadoopTables Lock Configuration
+
+When using `HadoopTables` (tables without a catalog), a `LockManager` can be
configured to ensure atomic commits on file systems like S3 that lack native
write mutual exclusion. Lock properties must be prefixed with
`iceberg.tables.hadoop.`.
+
+| Property | Default | Description
|
+| ------------------------------------------- | --------------- |
------------------------------------------------------ |
+| iceberg.tables.hadoop.lock-impl | null | a custom
implementation of the lock manager (e.g.,
`org.apache.iceberg.aws.dynamodb.DynamoDbLockManager`) |
+| iceberg.tables.hadoop.lock.table | null | an auxiliary
table for locking (e.g., DynamoDB table name) |
+| iceberg.tables.hadoop.lock.acquire-interval-ms | 5000 (5 s) | the interval
to wait between each attempt to acquire a lock |
+| iceberg.tables.hadoop.lock.acquire-timeout-ms | 180000 (3 min) | the
maximum time to try acquiring a lock |
+| iceberg.tables.hadoop.lock.heartbeat-interval-ms | 3000 (3 s) | the interval
to wait between each heartbeat after acquiring a lock |
+| iceberg.tables.hadoop.lock.heartbeat-timeout-ms | 15000 (15 s) | the
maximum time without a heartbeat to consider a lock expired |
Review Comment:
Thanks for the feedback! Updated to remove the duplicate table and instead
link to the existing Lock catalog properties section.
Here's the updated local rendering:
<img width="1891" height="981" alt="image"
src="https://github.com/user-attachments/assets/58039e38-b99f-4124-94cd-fd9247f95703"
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]