kevinjqliu commented on code in PR #3124:
URL: https://github.com/apache/iceberg-python/pull/3124#discussion_r2906870725
##########
pyiceberg/table/__init__.py:
##########
@@ -614,6 +614,54 @@ def overwrite(
for data_file in data_files:
append_files.append_data_file(data_file)
+ def replace(
Review Comment:
lets add `replace` on its own since its a pretty significant change and
follow up with table compaction.
i think there are a few more things we need to add to the `replace`
operation. Would be a good idea to look into the java side. For example, how
can we ensure that the table's data remains the same? REPLACE means no data
change. If we cannot guarantee that the data remains the same, maybe we should
not expose a `replace` function that takes a `df` as a parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
