rdblue commented on code in PR #15561:
URL: https://github.com/apache/iceberg/pull/15561#discussion_r2913418824
##########
core/src/main/java/org/apache/iceberg/SerializableTable.java:
##########
@@ -83,7 +80,7 @@ protected SerializableTable(Table table) {
Map<Integer, PartitionSpec> specs = table.specs();
specs.forEach((specId, spec) -> specAsJsonMap.put(specId,
PartitionSpecParser.toJson(spec)));
this.sortOrderAsJson = SortOrderParser.toJson(table.sortOrder());
- this.io = fileIO(table);
+ this.io = SerializableFileIO.copyOf(table.io());
Review Comment:
We could add a flag to not serialize `FileIO` because it comes from the
scan, but that probably isn't worth it. This is really just a problem for
Hadoop and fixing `HadoopFileIO` serialization is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
