chrislusf commented on code in PR #15577:
URL: https://github.com/apache/iceberg/pull/15577#discussion_r2916341577
##########
docker/iceberg-flink-quickstart/docker-compose.yml:
##########
@@ -92,43 +92,56 @@ services:
AWS_REGION: us-east-1
CATALOG_WAREHOUSE: s3://warehouse/
CATALOG_IO__IMPL: org.apache.iceberg.aws.s3.S3FileIO
- CATALOG_S3_ENDPOINT: http://minio:9000
+ CATALOG_S3_ENDPOINT: http://seaweedfs:8333
CATALOG_S3_ACCESS__KEY__ID: admin
CATALOG_S3_SECRET__ACCESS__KEY: password
- # MinIO for S3-compatible object storage
- minio:
- image: minio/minio
- hostname: minio
+ # SeaweedFS for S3-compatible object storage (mini mode)
+ seaweedfs:
+ image: chrislusf/seaweedfs:latest
Review Comment:
addressed in 27b33d3a94d0dd803d30cce0af8b10702f51658e
I changed `kafka-connect/kafka-connect-runtime/docker/docker-compose.yml` to
specific tag. It is used for CI, and better not fail due to docker image
changes.
Other places are mostly for documentation purpose. Having a specific version
in the documentation is an eyesore and may waste efforts to keep things
up-to-date. So I just cleaned up the tag. Let me know how you feel about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
