amogh-jahagirdar commented on code in PR #15572:
URL: https://github.com/apache/iceberg/pull/15572#discussion_r2920307550
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTScanPlanning.java:
##########
@@ -953,4 +1010,71 @@ public void serverSupportsPlanningButNotCancellation()
throws IOException {
// Verify no exception was thrown - cancelPlan returns false when endpoint
not supported
assertThat(cancelled).isFalse();
}
+
+ @Test
+ public void serverConfigTakesPrecedenceOnMismatch() {
+ // Client=SERVER, Server=CLIENT → server wins → effective=CLIENT → returns
BaseTable
Review Comment:
Minor: Not a useful comment, it's clear from the test name that we desire
server config to take precedence and we shouldn't really have comments that
outline how internal implementation works (i.e. "return baseTable") because
that stuff can always change and these comments become dated. It's below the
abstraction we care about here.
I'd maybe comment just the "Client=Server, Server=Client" part just because
the test has both this and the opposite case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
