danielcweeks commented on code in PR #15450:
URL: https://github.com/apache/iceberg/pull/15450#discussion_r2921229980


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4693,6 +4729,58 @@ components:
           allOf:
             - $ref: '#/components/schemas/Expression'
 
+    MultiValuedMap:
+      description: A map of string keys where each key can map to multiple 
string values.
+      type: object
+      additionalProperties:
+        type: array
+        items:
+          type: string
+
+    RemoteSignRequest:
+      description: The request to be signed remotely.
+      type: object
+      required:
+        - region
+        - uri
+        - method
+        - headers
+      properties:
+        region:
+          type: string
+        uri:
+          type: string
+        method:
+          type: string
+          enum: ["PUT", "GET", "HEAD", "POST", "DELETE", "PATCH", "OPTIONS"]
+        headers:
+          $ref: '#/components/schemas/MultiValuedMap'
+        properties:
+          type: object
+          additionalProperties:
+            type: string
+        body:
+          type: string
+          description: Optional body of the request to send to the signing 
API. This should only be populated
+            for requests where the body of the message contains content which 
must be validated before a request is
+            signed, such as the S3 DeleteObjects call.
+        provider:
+          type: string
+          description: The storage provider for which the request is to be 
signed. For backwards compatibility, if

Review Comment:
   Do we want to add some context in the description here as to what we should 
expect for these values?  I don't want to have a hard coded enumeration of 
cloud providers (limits extensibility), but I'm ok with saying something like
   
   > The provider should correspond to the scheme used for a storage native 
URI.  For example `s3` for AWS S3 paths.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to