yingjianwu98 commented on code in PR #15588:
URL: https://github.com/apache/iceberg/pull/15588#discussion_r2921555285
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/TestSparkWriteConf.java:
##########
@@ -450,6 +450,34 @@ public void testExtraSnapshotMetadataPersistedOnWrite() {
});
}
+ @TestTemplate
+ public void testExtraSnapshotMetadataPersistedOnDelete() {
+ String propertyKey = "test-key";
+ String propertyValue = "session-value";
+
+ // use a v1 table so that DELETE goes through SparkTable.deleteWhere()
Review Comment:
Sorry was not clear here.
For v2 and v3, a full partition delete indeed go through this but a row
level delete I believe will go through SparkPositionDeltaWrite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
