nastra commented on code in PR #15561:
URL: https://github.com/apache/iceberg/pull/15561#discussion_r2922634002
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -212,14 +213,17 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
}
}
- private FileIO fileIOForPlanId(List<Credential> storageCredentials) {
+ private FileIO scanFileIO(List<Credential> storageCredentials) {
+ ImmutableMap.Builder<String, String> builder =
+ ImmutableMap.<String, String>builder().putAll(catalogProperties);
+ if (null != planId) {
+ builder.put(RESTCatalogProperties.REST_SCAN_PLAN_ID, planId);
Review Comment:
this hasn't been released and we can still change it, but this should most
likely be done in a separate PR because that property is being used in a few
other places as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
