adp2201 commented on PR #13225: URL: https://github.com/apache/iceberg/pull/13225#issuecomment-4049936114
Thanks for the update on this PR. I reviewed the recent discussion and this looks close. I have one suggestion that might help with merge confidence: Could we make the security/behavior contract explicit in Javadocs (or nearby API docs), especially for: 1. Expected metadata access path for encrypted tables (what is trusted / not trusted), 2. How expectations should be handled by custom table-ops implementations, 3. What guarantees Iceberg provides vs what is caller/implementation responsibility when replacing default REST table operations. If possible, adding one focused negative test (or equivalent assertion) for custom/unsafe table-ops behavior would also make this easier to reason about for downstream users. Overall, appreciate the work here. This is an important capability for REST catalog users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
