PranjalChaitanya commented on code in PR #779:
URL: https://github.com/apache/iceberg-go/pull/779#discussion_r2932079784
##########
table/arrow_utils.go:
##########
@@ -832,7 +872,12 @@ func (a *arrowProjectionVisitor) Struct(st
iceberg.StructType, structArr arrow.A
} else if !field.Required {
dt := retOrPanic(TypeToArrowType(field.Type, false,
a.useLargeTypes))
- arr =
array.MakeArrayOfNull(compute.GetAllocator(a.ctx), dt, structArr.Len())
+ if field.WriteDefault != nil {
Review Comment:
I believe that modifying the signature of ToRequestedSchema would also
require me to change the signature of the other listed functions such as
VisitSchemaWithPartner, visitStructWithPartner, and Struct to propagate the
flag.
My issue with this is that some of these functions such as
VisitSchemaWithPartner seem to be used outside the scope of basic reading and
writing. For example, VisitSchemaWithPartner is used by name_mapping, and I'm
not sure what flag I would pass in here.
I fear that changing all of the signatures may be too large of a change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
