swapna267 commented on code in PR #15471:
URL: https://github.com/apache/iceberg/pull/15471#discussion_r2933733544


##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkWriteOptions.java:
##########
@@ -91,4 +91,11 @@ private FlinkWriteOptions() {}
   //  specify the uidSuffix to be used for the underlying IcebergSink
   public static final ConfigOption<String> UID_SUFFIX =
       ConfigOptions.key("uid-suffix").stringType().defaultValue("");
+
+  public static final ConfigOption<Integer> CACHE_MAX_SIZE =

Review Comment:
   When adding the config, i wanted to also use this for Table cache and 
serializer cache inside Dynamic Sink. 
   
   We need changes to Dynamic Sink itself to read Branch / Write parallelism / 
Cache size from Write Properties. 
   Didn't want to include them in this PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to