rdblue commented on code in PR #15049:
URL: https://github.com/apache/iceberg/pull/15049#discussion_r2934051269
##########
api/src/main/java/org/apache/iceberg/FileContent.java:
##########
@@ -18,11 +18,13 @@
*/
package org.apache.iceberg;
-/** Content type stored in a file, one of DATA, POSITION_DELETES, or
EQUALITY_DELETES. */
+/** Content type stored in a file. */
public enum FileContent {
DATA(0),
POSITION_DELETES(1),
- EQUALITY_DELETES(2);
+ EQUALITY_DELETES(2),
+ DATA_MANIFEST(3),
+ DELETE_MANIFEST(4);
Review Comment:
I doubt we check this in the write path, which means that if this were
actually used we would produce files with bad IDs. It's probably a good idea to
look through how writes take place and build some confidence that we won't see
this from the v2 or v3 writers. We need to do that for v4 anyway (since this
creates the potential to write v4 content types into v3) so we should just do
it now before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
