starpact opened a new pull request, #783: URL: https://github.com/apache/iceberg-go/pull/783
`postCommit` of `removeSnapshotsUpdate` is ignored when applied to `MetadataBuilfer`, so it actually never takes effect. https://github.com/apache/iceberg-go/blob/a012a1770d70e0df6babcb63e42058f484390602/table/metadata.go#L508 I made postCommit part of the constructor, as otherwise we have to this: https://github.com/apache/iceberg-go/blob/a012a1770d70e0df6babcb63e42058f484390602/table/transaction.go#L300-L301 which seems pretty error-prone. Though this is technically a breaking change for a somewhat internal API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
