pvary commented on code in PR #15508:
URL: https://github.com/apache/iceberg/pull/15508#discussion_r2940911408
##########
core/src/main/java/org/apache/iceberg/avro/ValueReaders.java:
##########
@@ -254,6 +254,9 @@ private static Pair<Integer, ValueReader<?>>
fileFieldReader(
Integer projectionPos,
ValueReader<?> fieldReader,
Map<Integer, ?> idToConstant) {
+ if (projectionPos == null && !idToConstant.containsKey(fieldId)) {
+ return Pair.of(projectionPos, fieldReader);
+ }
if (Objects.equals(fieldId, MetadataColumns.ROW_ID.fieldId())) {
Review Comment:
Sorry - the other way around... We don't need the check for the
`projectionPos` anymore. We did that in the caller method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
