amogh-jahagirdar commented on PR #15654:
URL: https://github.com/apache/iceberg/pull/15654#issuecomment-4069810492
OK core tests in 1.10 with this because:
```
TestRowDelta > testCannotMergeDVsMismatchedSequenceNumbers() > formatVersion
= 3, branch = main FAILED
java.lang.IllegalArgumentException: Content offset is required for DV
at
org.apache.iceberg.relocated.com.google.common.base.Preconditions.checkArgument(Preconditions.java:141)
at
org.apache.iceberg.FileMetadata$Builder.build(FileMetadata.java:259)
at
org.apache.iceberg.TestRowDelta.testCannotMergeDVsMismatchedSequenceNumbers(TestRowDelta.java:2201)
```
that's a new test I added as part of the original change but the test relies
on making sure DV fields are properly copied over in the FileMetadata builder
`copy(DeleteFile)` api, and that was fixed in a
PRhttps://github.com/apache/iceberg/pull/14351 . I think there's a good
argument that we should backport #14351 first because that's simply a
correctness problem in that API without that fix (I would expect copy to always
preserve those fields as is) but I'm not sure if this will cause behavior
changes in the backport release, will check that out further.
If not, then we just update this test in this 1.10 branch to just explicitly
pass through the value in the builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
