adp2201 commented on PR #14797: URL: https://github.com/apache/iceberg/pull/14797#issuecomment-4071512190
Thanks for the follow-up and for adding the docs in `08deadee81d0`. I went through the latest diff and had two things I wanted to flag before we call this done: 1. In `Operation.fromString`, unknown CDC op values currently fall back to `INSERT`. That feels risky for data correctness (silent bad writes) vs failing fast with a clear error. 2. The docs around format version read a bit inconsistent (`> 2` in one place, but V2 behavior is described/tested elsewhere). Could we tighten that wording so users know exactly what is supported? Also, given the duplicate/recovery discussion (and `#15651`), do we want this PR rebased on that fix, or should we add a deterministic regression test here to prove recovery behavior is safe? If you agree, I can help with a small follow-up commit for the validation + docs wording cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
