pvary commented on code in PR #15663:
URL: https://github.com/apache/iceberg/pull/15663#discussion_r2946548653
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSplitPlanner.java:
##########
@@ -72,17 +75,41 @@ static FlinkInputSplit[] planInputSplits(
/** This returns splits for the FLIP-27 source */
public static List<IcebergSourceSplit> planIcebergSourceSplits(
Table table, ScanContext context, ExecutorService workerPool) {
- try (CloseableIterable<CombinedScanTask> tasksIterable =
- planTasks(table, context, workerPool)) {
+ try (PlanResult planResult = planTasks(table, context, workerPool)) {
return Lists.newArrayList(
- CloseableIterable.transform(tasksIterable,
IcebergSourceSplit::fromCombinedScanTask));
+ CloseableIterable.transform(
+ planResult.tasks(),
+ task -> IcebergSourceSplit.fromCombinedScanTask(task,
planResult.fileIO().get())));
Review Comment:
Do we have an inkling how the supplier will be implemented? Maybe calling
get for every split would be an overkill?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
