rockwotj commented on PR #803: URL: https://github.com/apache/iceberg-go/pull/803#issuecomment-4086444091
> looks good, flag polarity is correct, and both methods are covered: mergeable as-is. That said, would really like to see at least one test: AddDataFiles with WithoutAutoNameMapping() against a table without an existing name mapping, asserting DefaultNameMappingKey is absent after commit — that's the exact UC failure path this PR is fixing. Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
