RussellSpitzer commented on code in PR #15614:
URL: https://github.com/apache/iceberg/pull/15614#discussion_r2957061769
##########
core/src/main/java/org/apache/iceberg/CatalogProperties.java:
##########
@@ -80,6 +80,29 @@ private CatalogProperties() {}
public static final boolean IO_MANIFEST_CACHE_ENABLED_DEFAULT = false;
+ /**
+ * Controls whether engines using a REST Catalog should delegate DROP TABLE
PURGE requests to the
+ * catalog server instead of performing client-side file deletion.
+ *
+ * <p>When enabled (true), the engine sends the purge request to the REST
catalog, allowing the
+ * catalog to handle deletion. This enables features like UNDROP for REST
catalogs that preserve
+ * deleted table metadata.
+ *
+ * <p>When disabled (false, default), the engine lists and deletes files
client-side before
+ * dropping the table. This provides parallelized deletion but prevents
server-side purge
+ * features.
+ *
+ * <p><b>Deprecation notice:</b> Client-side purge for REST catalogs is
deprecated and will be
+ * removed in Apache Iceberg 2.0. The default will change to true in a
future release. Non-REST
+ * catalog implementations (Hive, Glue, Hadoop) will maintain client-side
behavior for
+ * compatibility.
+ *
+ * <p>Defaults to false for backward compatibility.
+ */
+ public static final String REST_CATALOG_PURGE = "rest.catalog-purge";
Review Comment:
So I'm a little against keeping this property here since it only applies to
Spark at the moment right? If we want it to apply to other engines I think it's
ok but may fit better in RestCatalogProperties.
If it was going to be spark only I would have suggested a Spark only
properties file but we don't have one for Spark Catalog properties which is a
bit annoying. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
