nastra commented on code in PR #15448:
URL: https://github.com/apache/iceberg/pull/15448#discussion_r2958285608
##########
spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/source/TestRemoteScanPlanning.java:
##########
@@ -38,8 +49,6 @@ protected static Object[][] parameters() {
ImmutableMap.builder()
.putAll(SparkCatalogConfig.REST.properties())
.put(CatalogProperties.URI,
restCatalog.properties().get(CatalogProperties.URI))
- // this flag is typically only set by the server, but we set it
from the client for
Review Comment:
we still need the client setup but the reason why I added this comment
before was because previously the flag would only be something that the server
would be sending back and technically it wasn't something that a client would
configure. With the new planning modes that isn't true anymore and clients can
configure this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
