davseitsev commented on code in PR #12892:
URL: https://github.com/apache/iceberg/pull/12892#discussion_r2958884155
##########
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##########
@@ -123,12 +125,21 @@ public void initialize(String name, Map<String, String>
properties) {
properties.get(CatalogProperties.WAREHOUSE_LOCATION),
new AwsProperties(properties),
AwsClientFactories.from(properties).dynamo(),
- initializeFileIO(properties));
+ initializeFileIO(properties),
+ PropertyUtil.propertyAsBoolean(
+ properties,
+ CatalogProperties.UNIQUE_TABLE_LOCATION,
+ CatalogProperties.UNIQUE_TABLE_LOCATION_DEFAULT));
}
@VisibleForTesting
void initialize(
- String name, String path, AwsProperties properties, DynamoDbClient
client, FileIO io) {
+ String name,
+ String path,
+ AwsProperties properties,
+ DynamoDbClient client,
+ FileIO io,
+ boolean uniqTableLocation) {
Review Comment:
I committed the change and then rolled it back. Changing
`uniqueTableLocation` to `uniqTableLocation` fails the build,
`iceberg-aws:checkstyleMain` fails with `'uniqueTableLocation' hides a field`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
