mxm commented on code in PR #15672:
URL: https://github.com/apache/iceberg/pull/15672#discussion_r2958975273


##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DataFileRewriteRunner.java:
##########
@@ -122,11 +123,12 @@ public void processElement(PlannedGroup value, Context 
ctx, Collector<ExecutedGr
 
         Set<DataFile> dataFiles = Sets.newHashSet(writer.dataFiles());
         value.group().setOutputFiles(dataFiles);
+        Snapshot snapshot =
+            value.branch() != null

Review Comment:
   Agreed, this is cleaner. The existing logic allowed for both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to