adutra commented on code in PR #15500:
URL: https://github.com/apache/iceberg/pull/15500#discussion_r2962134748
##########
gradle/libs.versions.toml:
##########
@@ -111,6 +112,7 @@ awssdk-bom = { module = "software.amazon.awssdk:bom",
version.ref = "awssdk-bom"
awssdk-s3accessgrants = { module =
"software.amazon.s3.accessgrants:aws-s3-accessgrants-java-plugin", version.ref
= "awssdk-s3accessgrants" }
azuresdk-bom = { module = "com.azure:azure-sdk-bom", version.ref =
"azuresdk-bom" }
bson = { module = "org.mongodb:bson", version.ref = "bson-ver"}
+bouncycastle-bcpkix = { module = "org.bouncycastle:bcpkix-jdk18on",
version.ref = "bouncycastle" }
Review Comment:
Very good question! Short answer: yes.
MockServer *does* bring BouncyCastle transitively — bcprov, bcpkix, and
bcutil – but at version 1.72, which is somewhat old.
The problem is that other deps (Hadoop) bring bcprov 1.82, and Gradle
resolves the conflict by upgrading bcprov to 1.82. But bcpkix and bcutil stay
at 1.72, since nothing else declares a higher version. This creates a mismatch:
bcpkix 1.72 + bcprov 1.82 = `NoClassDefFoundError`.
I only upgraded bcpkix here, because that is enough for running the TLS
tests. If you prefer, I can also explicitly upgrade bcutil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
