jbewing commented on code in PR #15681:
URL: https://github.com/apache/iceberg/pull/15681#discussion_r2963622009


##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteRequirements.java:
##########
@@ -54,6 +56,8 @@ public boolean hasOrdering() {
 
   public long advisoryPartitionSize() {
     // Spark prohibits requesting a particular advisory partition size without 
distribution
-    return distribution instanceof UnspecifiedDistribution ? 0 : 
advisoryPartitionSize;
+    return distribution instanceof UnspecifiedDistribution

Review Comment:
   👍 , addressed in 
https://github.com/apache/iceberg/pull/15681/changes/0ff2adb12733d838388ba81df7e9e803538b14ef



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to