danielcweeks commented on code in PR #15696:
URL: https://github.com/apache/iceberg/pull/15696#discussion_r2966579222
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSFileIO.java:
##########
@@ -199,13 +211,67 @@ private Map<String, PrefixedStorage> storageByPrefix() {
storageSupplier));
});
this.storageByPrefix = localStorageByPrefix;
+ scheduleCredentialRefresh();
Review Comment:
We should be refreshing at minimum 5 minutes before which is pretty
consistent across implementations. There's always the chance that you could
serialize right before that point, but it's actually pretty unlikely since most
loads/scans start within seconds of access. It's probably better to think
about jittering the refresh in the credential provider.
Just updating at serialization time is where I started originally, which is
relatively easy for java serialization but not for kryo due to needing to
register the class with kryo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
