CTTY commented on code in PR #2232:
URL: https://github.com/apache/iceberg-rust/pull/2232#discussion_r2966886857
##########
crates/catalog/s3tables/src/catalog.rs:
##########
@@ -581,6 +581,14 @@ impl Catalog for S3TablesCatalog {
Ok(())
}
+ /// Purge a table from the S3 Tables catalog.
+ ///
+ /// S3 Tables data is managed by the service, so this just delegates
+ /// to `drop_table`
+ async fn purge_table(&self, table: &TableIdent) -> Result<()> {
+ self.drop_table(table).await
Review Comment:
S3 Tables doesn't support `purge=false`, so `drop_table` and `purge_table`
should behave the same.
The "correct" way would be throwing error in `drop_table` and I think that's
too inconvenient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
