RussellSpitzer commented on a change in pull request #1852: URL: https://github.com/apache/iceberg/pull/1852#discussion_r532629516
########## File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/DeleteFromTablePredicateCheck.scala ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.catalyst.analysis + +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.expressions.{Expression, InSubquery, Not} +import org.apache.spark.sql.catalyst.plans.logical.{DeleteFromTable, LogicalPlan} + +object DeleteFromTablePredicateCheck extends (LogicalPlan => Unit) { + + override def apply(plan: LogicalPlan): Unit = { + plan foreach { + case DeleteFromTable(_, Some(condition)) if hasNullAwarePredicateWithinNot(condition) => + // this limitation is present since SPARK-25154 fix is not yet available + // we use Not(EqualsNullSafe(cond, true)) when deciding which records to keep + // such conditions are rewritten by Spark as an existential join and currently Spark + // does not handle correctly NOT IN subqueries nested into other expressions + failAnalysis("Null-aware predicate sub-queries are not currently supported in DELETE") + + case _ => // OK + } + } + + private def hasNullAwarePredicateWithinNot(cond: Expression): Boolean = { + cond.find { + case Not(expr) if expr.find(_.isInstanceOf[InSubquery]).isDefined => true Review comment: do we have to worry about "In" as well? Or only InSubquery? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
